Support stripping metadata from updates. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facetoe
force-pushed
the
will-strip-metadata
branch
2 times, most recently
from
6a6db32 to
8b8d15d
Compare
Updates metadata can be quite large and cause systems with low memory to OOM refreshing it. Add support for dropping from the metadata architectures that are not in use in any system the mirror serves. This is achieved in much the same way as snapshotting is implemneted: pull metadata, rewrite, update the various values like checksum and size so DNF is happy to consume it and add to repomd.xml. Some refactoring was performed as much of the code used for snapshotting is also useful here.
facetoe
force-pushed
the
will-strip-metadata
branch
from
8b8d15d to
510cc59
Compare
derrix060
reviewed
Aug 15, 2022
Follow on from previous commit and support stripping xz metadata also.
facetoe
force-pushed
the
will-strip-metadata
branch
from
510cc59 to
40654a1
Compare
lionbee
approved these changes
Aug 16, 2022
nicois
reviewed
Aug 16, 2022
nicois
reviewed
Aug 16, 2022
| target_arches: Tuple[str], | ||
| scratch_dir: str, | ||
| ): | ||
| sync_files, upload_files = [], [] |
There was a problem hiding this comment.
nit: sync_files is never modified, which makes mypy sad.
There was a problem hiding this comment.
I might see about adding mypy lint step and adding proper typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates metadata can be quite large and cause systems with low memory to
OOM refreshing it. Add support for dropping from the metadata
architectures that are not in use in any system the mirror serves. This
is achieved in much the same way as snapshotting is implemneted: pull
metadata, rewrite, update the various values like checksum and size so
DNF is happy to consume it and add to repomd.xml.
Some refactoring was performed as much of the code used for snapshotting
is also useful here.